Stabilize the stdarch_neon_dotprod feature#2120
Open
lupodevelop wants to merge 1 commit into
Open
Conversation
Stabilizes the NEON dot product intrinsics tracked by rust-lang/rust#117224: vdot{q}_{s,u}32 vdot{q}_lane_{s,u}32 vdot{q}_laneq_{s,u}32 These have been available unstably since 2023. The `dotprod` target feature and `is_aarch64_feature_detected!("dotprod")` are already stable, so this only flips the intrinsics' stability attribute on aarch64 and arm64ec. On AArch32 the intrinsics remain unstable under `stdarch_arm_neon_intrinsics` (rust-lang/rust#111800), consistent with the rest of the AArch32 NEON surface.
Collaborator
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilizes the NEON dot product intrinsics (vdot*), tracking issue rust-lang/rust#117224.
Gated behind stdarch_neon_dotprod since 2023. The dotprod target feature and is_aarch64_feature_detected!("dotprod") are already stable, so this is an attribute-only change, same pattern as the fp16 stabilization in 0f9516b.
The vdot*_laneq* blocks had a plain unstable with no arch split.
I gave them the not(arm) split like the others for consistency.
Regenerated with stdarch-gen-arm, the diff is the stability attribute only.
Needs an FCP.